Implement Secrets Vault Plugin #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
azizutku
commented
May 23, 2023
azizutku
commented
- Set up initial project
- Add detekt
- Add CPP resources and CMakeLists.txt
- Add initial kotlin file for secrets
- Implement task that unzip plugin to temp folder
- Implement utility methods
- Implement code generator methods
- Add capitalize extension function to capitalize the first character
- Add kotlinx serialization dependency
- Implement keep secrets task
- Register KeepSecretsTask to the plugin
- Generate obfuscation key randomly
- Add CHANGELOG.md
- Add README.md
- Create build workflow
azizutku
requested review from
agabeyalioglu and
burakaygun
and removed request for
agabeyalioglu and
burakaygun
agabeyalioglu
requested changes
May 23, 2023
opsenes
approved these changes
Jun 22, 2023
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/KeepSecretsTask.kt
Outdated
Show resolved
Hide resolved
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/KeepSecretsTask.kt
Outdated
Show resolved
Hide resolved
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/KeepSecretsTask.kt
Outdated
Show resolved
Hide resolved
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/KeepSecretsTask.kt
Outdated
Show resolved
Hide resolved
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/KeepSecretsTask.kt
Outdated
Show resolved
Hide resolved
| * @return the destination file for the CPP code | ||
| */ | ||
| private fun getCppDestination(flavor: String, fileName: String): File { | ||
| return project.file(SOURCE_SET_TEMPLATE.format(flavor, "cpp") + fileName) |
There was a problem hiding this comment.
since project.layout.file returns provider, it is generally preferred(Of course providers can be used If we inject these as input/output)
There was a problem hiding this comment.
In this specific case, we don't have a Provider readily available, and so we cannot use project.layout.file. The method project.file is suitable in our current context, where we have a file path represented as a String.
| * | ||
| * @return the package name of the Android app | ||
| */ | ||
| private fun getAppPackageName(): String { |
There was a problem hiding this comment.
i think most of these methods would be better if they were defined as input/output properties
There was a problem hiding this comment.
I've moved these methods to the plugin extension.
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/SecretsVaultPlugin.kt
Outdated
Show resolved
Hide resolved
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/SecretsVaultPlugin.kt
Outdated
Show resolved
Hide resolved
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/KeepSecretsTask.kt
Outdated
Show resolved
Hide resolved
secretsvaultplugin/src/main/kotlin/com/commencis/secretsvaultplugin/KeepSecretsTask.kt
Outdated
Show resolved
Hide resolved
| * @return a string containing the generated C++ code for app signature check | ||
| */ | ||
| fun getAppSignatureCheck(appSignatures: List<String>): String { | ||
| val signatures = appSignatures.joinToString(separator = "") { " $it,\n" }.trimEnd(',', '\n') |
There was a problem hiding this comment.
{ " $it,\n" }
can we use \t instead of whitespaces?
There was a problem hiding this comment.
I prefer to use spaces for indentation as the size of a tab character can vary between different IDEs, potentially leading to inconsistent formatting. Using spaces ensures that our code looks the same everywhere.
agabeyalioglu
approved these changes
Aug 9, 2023
burakaygun
approved these changes
Aug 9, 2023
| alias(libs.plugins.gradle.publish).apply(false) | ||
| alias(libs.plugins.detekt).apply(false) | ||
| alias(libs.plugins.kotlin.serialization).apply(false) | ||
| } |
| import java.io.IOException | ||
| import java.nio.charset.Charset | ||
|
|
||
| private const val SOURCE_SET_TEMPLATE = "src/%1\$s/%2\$s/" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.