Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reclassed financial value #278

Closed
wants to merge 1 commit into from
Closed

reclassed financial value #278

wants to merge 1 commit into from

Conversation

cameronmore
Copy link
Contributor

No description provided.

@cameronmore cameronmore linked an issue Jun 16, 2024 that may be closed by this pull request
Should “Financial Value” be a quality? #199
Open
@cameronmore
Copy link
Contributor Author

I looked across the ontologies and I don't see anything that breaks because of this semantic change, but others should verify this.

@jonathanvajda
Copy link

The thread on the issue tracker might make better sense a discussion. I recommend a theory gets endorsed first, and then the appropriate changes be made. This request seems premature.

jonathanvajda
jonathanvajda suggested changes Aug 6, 2024
View reviewed changes
Copy link

@jonathanvajda jonathanvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a change that requires deprecation.

@cameronmore cameronmore closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanvajda jonathanvajda jonathanvajda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should “Financial Value” be a quality?
2 participants
@cameronmore @jonathanvajda