Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UITests: Remove ref to incorrect version of winui #4226

Merged
merged 1 commit into from
Sep 3, 2021
Merged

UITests: Remove ref to incorrect version of winui #4226

merged 1 commit into from
Sep 3, 2021

Conversation

Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Sep 3, 2021

Fixes "NU1605: Detected package downgrade: Microsoft.UI.Xaml from 2.6.2 to 2.6.1. Reference the package directly from the project to select a different version."

It seems we forgot to update the winui ref in the UITest.App project ( The added winui ref was prob in a PR when the winui update PR merged.) The mixed versions causes warning is visual studio and could mess with out tests env.

PR Type

What kind of change does this PR introduce?
Remove the explicit winui ref in UITest.App.

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Sep 3, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi September 3, 2021 19:17
@michael-hawker
Copy link
Member

@RosarioPulella looks good, this should be pulled in anyway from the other projects. Any reason this is a Draft PR?

@Rosuavio Rosuavio marked this pull request as ready for review September 3, 2021 19:40
@Rosuavio
Copy link
Contributor Author

Rosuavio commented Sep 3, 2021

@huynhsontung I saw that you added the packaged reference in #3650, it does not seem needed to me, if there was a good reason for adding it I can update the package version instead of removing the reference.

@Rosuavio
Copy link
Contributor Author

Rosuavio commented Sep 3, 2021

@RosarioPulella looks good, this should be pulled in anyway from the other projects. Any reason this is a Draft PR?

Just want to make 100% sure the ref is not needed. But it seems fine to merge either way.

@huynhsontung
Copy link
Contributor

@RosarioPulella the UI tests passed so the reference is indeed not needed. Thank you for removing it.

@michael-hawker michael-hawker added this to the 7.1 milestone Sep 3, 2021
@michael-hawker michael-hawker merged commit 984fe18 into CommunityToolkit:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants