Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: arduino library specification compliance #18

Merged
merged 6 commits into from
Sep 8, 2024
Merged

feat: arduino library specification compliance #18

merged 6 commits into from
Sep 8, 2024

Conversation

Bissas
Copy link
Collaborator

@Bissas Bissas commented Sep 8, 2024

Changes

  • Repository is now fully compliant with the Arduino Library Specification.
  • Added a linter workflow that checks for compliance on pushes and on pull requests.

@Bissas Bissas requested a review from erlestor September 8, 2024 11:37
@Bissas Bissas self-assigned this Sep 8, 2024
@Bissas Bissas linked an issue Sep 8, 2024 that may be closed by this pull request
Arduino Library Specification compliance #17
Closed
@Bissas Bissas marked this pull request as ready for review September 8, 2024 11:38
erlestor
erlestor approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@erlestor erlestor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

aheyerdahl
aheyerdahl approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@aheyerdahl aheyerdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bissas Bissas merged commit 999d010 into main Sep 8, 2024
6 checks passed
@Bissas Bissas deleted the 17-arduino-library-specification-compliance branch September 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheyerdahl aheyerdahl aheyerdahl approved these changes

@erlestor erlestor erlestor approved these changes

Assignees

@Bissas Bissas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arduino Library Specification compliance
3 participants
@Bissas @aheyerdahl @erlestor