solana-trie: add support for witness account #1731
master.yml
on: pull_request
Miscellaneous checks
2m 54s
Anchor Test
20m 5s
Rust tests
8m 38s
Annotations
8 errors and 2 warnings
deref on an immutable reference:
solana/trie/src/lib.rs#L160
error: deref on an immutable reference
--> solana/trie/src/lib.rs:160:40
|
160 | let root: &witness::Data = &*witness;
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::borrow_deref_ref)]`
help: if you would like to reborrow, try removing `&*`
|
160 | let root: &witness::Data = witness;
| ~~~~~~~
help: if you would like to deref, try using `&**`
|
160 | let root: &witness::Data = &**witness;
| ~~~~~~~~~~
|
this lifetime isn't used in the impl:
solana/trie/src/lib.rs#L150
error: this lifetime isn't used in the impl
--> solana/trie/src/lib.rs:150:10
|
150 | impl<'a, 'info, D: DataRef> core::ops::DerefMut for TrieAccount<'a, D> {
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
|
this lifetime isn't used in the impl:
solana/trie/src/lib.rs#L145
error: this lifetime isn't used in the impl
--> solana/trie/src/lib.rs:145:10
|
145 | impl<'a, 'info, D: DataRef> core::ops::Deref for TrieAccount<'a, D> {
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
|
this lifetime isn't used in the impl:
solana/trie/src/lib.rs#L118
error: this lifetime isn't used in the impl
--> solana/trie/src/lib.rs:118:10
|
118 | impl<'a, 'info, D: DataRef + Sized> core::ops::Drop for TrieAccount<'a, D> {
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
= note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::extra_unused_lifetimes)]`
|
this call to `as_mut` does nothing:
solana/trie/src/witness.rs#L64
error: this call to `as_mut` does nothing
--> solana/trie/src/witness.rs:64:35
|
64 | let data: &mut [u8] = data.as_mut();
| ^^^^^^^^^^^^^ help: try: `data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
= note: `-D clippy::useless-asref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_asref)]`
|
the following explicit lifetimes could be elided: 'info:
solana/trie/src/witness.rs#L60
error: the following explicit lifetimes could be elided: 'info
--> solana/trie/src/witness.rs:60:41
|
60 | pub(crate) fn from_account_info<'a, 'info>(
| ^^^^^
61 | witness: &'a AccountInfo<'info>,
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-D clippy::needless-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
60 ~ pub(crate) fn from_account_info<'a>(
61 ~ witness: &'a AccountInfo<'_>,
|
|
Miscellaneous checks
Clippy had exited with the 101 exit code
|
Rust tests
Process completed with exit code 101.
|
Miscellaneous checks
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Miscellaneous checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|