Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor update functions and add equations in the doctrings #132

Merged
merged 7 commits into from
Nov 7, 2023
Merged

refactor update functions and add equations in the doctrings #132

merged 7 commits into from
Nov 7, 2023

Conversation

LegrandNico
Copy link
Collaborator

@LegrandNico LegrandNico commented Nov 7, 2023 •
edited
Loading

  • Store the predicted volatility in the node attribute to avoid computing it multiple times.
  • Add math equation to most of the update functions
  • Use update equation that follows as much as possible the paper

This should close #128

@LegrandNico LegrandNico added documentation Improvements or additions to documentation update functions performances labels Nov 7, 2023
@LegrandNico LegrandNico merged commit a0077c5 into master Nov 7, 2023
4 checks passed
@LegrandNico LegrandNico deleted the updates branch November 7, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation performances update functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error in the multi children continuous HGF
1 participant
@LegrandNico