-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix memory leak #44
Merged
psychocoderHPC
merged 1 commit into
ComputationalRadiationPhysics:dev
from
michaelsippel:topic-chunkedlist-delete
Dec 8, 2023
Merged
fix memory leak #44
psychocoderHPC
merged 1 commit into
ComputationalRadiationPhysics:dev
from
michaelsippel:topic-chunkedlist-delete
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh()` by decrementing its item count after each insertion of a new chunk
psychocoderHPC
merged commit Dec 8, 2023
7f2c3e4
into
ComputationalRadiationPhysics:dev
1 check passed
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 11, 2023
With ComputationalRadiationPhysics#44 we tried to fix the memory leak which can happen if more than one thread is allocating a new chunk. The PR ComputationalRadiationPhysics#44 was not fixing the issue and introduces a double free issue.
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 11, 2023
With ComputationalRadiationPhysics#44 we tried to fix the memory leak which can happen if more than one thread is allocating a new chunk. The PR ComputationalRadiationPhysics#44 was not fixing the issue and introduces a double free issue.
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 11, 2023
With ComputationalRadiationPhysics#44 we tried to fix the memory leak which can happen if more than one thread is allocating a new chunk. The PR ComputationalRadiationPhysics#44 was not fixing the issue and introduces a double free issue.
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 11, 2023
With ComputationalRadiationPhysics#44 we tried to fix the memory leak which can happen if more than one thread is allocating a new chunk. The PR ComputationalRadiationPhysics#44 was not fixing the issue and introduces a double free issue.
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 11, 2023
With ComputationalRadiationPhysics#44 we tried to fix the memory leak which can happen if more than one thread is allocating a new chunk. The PR ComputationalRadiationPhysics#44 was not fixing the issue and introduces a double free issue.
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 12, 2023
With ComputationalRadiationPhysics#44 we tried to fix the memory leak which can happen if more than one thread is allocating a new chunk. The PR ComputationalRadiationPhysics#44 was not fixing the issue and introduces a double free issue.
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 12, 2023
…l/topic-chunkedlist-delete fix memory leak
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 12, 2023
With ComputationalRadiationPhysics#44 we tried to fix the memory leak which can happen if more than one thread is allocating a new chunk. The PR ComputationalRadiationPhysics#44 was not fixing the issue and introduced a double free issue.
psychocoderHPC
added a commit
to psychocoderHPC/redGrapes
that referenced
this pull request
Dec 12, 2023
With ComputationalRadiationPhysics#44 we tried to fix the memory leak which can happen if more than one thread is allocating a new chunk. The PR ComputationalRadiationPhysics#44 was not fixing the issue and introduced a double free issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that linked chunks will not be deleted in case we insert more than one chunk during the detection that the current memory is full.