fix modulo zero #46
Closed
fix modulo zero #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l/topic-chunkedlist-delete fix memory leak
psychocoderHPC
force-pushed
the
fix-modZero
branch
from
d28f1e9 to
6702cdf
Compare
There was a problem hiding this comment.
If n_workers is 0 , we shouldnt be able to create an Allocator since the default constructor shall give the allocator of the current worker. Now that worker_id is initialized with 0 even though n_workers is also zero will cause an invalid memory access whenever allocate is called because the vector containing the allocators ( in WorkerPool ) does not have 0 as a valid index
Merged
|
The reason why I run into the issue I tried to fix with this PR is #47. The example was not implemented correctly. |
|
I set this PR for now to |
|
not required it was solved with #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulo zero is not allowed and results in an arithmetic error.
This is the first error I hit on my system with the example
1_resource. The dev branch is still not working on my laptop but this fixes one problem, other are under investigation.