Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AtomicList & improve ChunkedList #51

Merged
merged 4 commits into from
Dec 14, 2023
Merged

fix AtomicList & improve ChunkedList #51

merged 4 commits into from
Dec 14, 2023

Conversation

michaelsippel
Copy link
Member

  • AtomicList: fix ItemControlBlock (was missing initialization of deleted flag)
  • ChunkedList: always call all destructors for Item and remove unnecessary last_item member
  • add more comments

@michaelsippel michaelsippel force-pushed the topic-chunkedlist branch 3 times, most recently from fbcd59a to 0f19fe5 Compare December 14, 2023 00:09
psychocoderHPC
psychocoderHPC requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@psychocoderHPC psychocoderHPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase against the latest dev branch, I am wondering why the diff is against a version which is still including the initial allocation in the constructor where this is already changed in the dev branch.

@michaelsippel
Copy link
Member Author

Could you please rebase against the latest dev branch, I am wondering why the diff is against a version which is still including the initial allocation in the constructor where this is already changed in the dev branch.

rebased

@psychocoderHPC psychocoderHPC merged commit 0d58d87 into ComputationalRadiationPhysics:dev Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychocoderHPC psychocoderHPC psychocoderHPC approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsippel @psychocoderHPC