Refactor Task to make it smaller #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikbuibui
force-pushed
the
test_smaller_task
branch
from
bd913ab to
5392b90
Compare
ikbuibui
force-pushed
the
test_smaller_task
branch
from
5392b90 to
3390189
Compare
ikbuibui
force-pushed
the
test_smaller_task
branch
from
d639470 to
a782775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unused variables
Moved things around in structs for better alignment
Pool scheduler now holds WorkerPool instead of pointer to it
n_pus is initialized earlier
The vector of allocators for each worker is now held as an object and not a pointer