Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/aes128 #719

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/aes128 #719

wants to merge 3 commits into from

Conversation

jplaui
Copy link

@jplaui jplaui commented Jun 8, 2023

Please find my initial aes128 and aes128 gcm implementations in this pull request.
I have implemented the naive lookup of s-box values. possible s-box lookup optimizations can be found here: https://github.com/akosba/jsnark/tree/master/JsnarkCircuitBuilder/src/examples/gadgets/blockciphers/sbox

@ivokub
Copy link
Collaborator

ivokub commented Sep 6, 2023

Please find my initial aes128 and aes128 gcm implementations in this pull request. I have implemented the naive lookup of s-box values. possible s-box lookup optimizations can be found here: https://github.com/akosba/jsnark/tree/master/JsnarkCircuitBuilder/src/examples/gadgets/blockciphers/sbox

Thanks for the contribution. Unfortunately right now AES in not on gnark roadmap and it would take quite some time to review the PR is correct (and most importantly, sound). I think AES is definitely worth it and allows interesting applications. Lets keep the PR open until we have more time to get back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants