feat: Support FrIndexArray and FrMapArray
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This adds support for these two pool types, both of which are backed by the same 64K array of field elements. Overall, that leads to a fairly decent improvement in storage usage, as well as a small improvement in execution time.
DavePearce
force-pushed
the
252-support-frmaparray
branch
from
368397d to
9fb2253
Compare
This uses a map to pool `fr.Element` instances, long with appropriate locks to ensure thread-safety.
DavePearce
force-pushed
the
252-support-frmaparray
branch
from
9fb2253 to
5e99d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
FrIndexArrayandFrMapArray, along with variousFrPoolimplementations which are optimised for various cases. Perhaps surprisingly, whilst memory usage has been improved considerably, it still lags behind the original Rustcorsettool in many cases.