chore(contracts): Inconsistent ordering of functions in AbstractPortal (

#831)
Consensys · Nov 28, 2024 · f50828b · f50828b
1 parent ee8c5eb
commit f50828b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/contracts/src/abstracts/AbstractPortal.sol b/contracts/src/abstracts/AbstractPortal.sol
@@ -315,6 +315,16 @@ abstract contract AbstractPortal is IPortal, ERC165 {
     uint256 value
   ) internal virtual {}
 
+  /**
+   * @notice Optional method run when attesting a batch of payloads
+   * @param attestationsPayloads the payloads to attest
+   * @param validationPayloads the payloads to validate in order to issue the attestations
+   */
+  function _onBulkAttest(
+    AttestationPayload[] memory attestationsPayloads,
+    bytes[][] memory validationPayloads
+  ) internal virtual {}
+
   /**
    * @notice Optional method run when an attestation is replaced
    * @dev    IMPORTANT NOTE: By default, replacement is only possible by the portal owner
@@ -331,16 +341,6 @@ abstract contract AbstractPortal is IPortal, ERC165 {
     uint256 value
   ) internal virtual onlyPortalOwner {}
 
-  /**
-   * @notice Optional method run when attesting a batch of payloads
-   * @param attestationsPayloads the payloads to attest
-   * @param validationPayloads the payloads to validate in order to issue the attestations
-   */
-  function _onBulkAttest(
-    AttestationPayload[] memory attestationsPayloads,
-    bytes[][] memory validationPayloads
-  ) internal virtual {}
-
   /**
    * @notice Optional method run when replacing a batch of payloads
    * @dev    IMPORTANT NOTE: By default, bulk replacement is only possible by the portal owner

diff --git a/contracts/src/abstracts/AbstractPortalV2.sol b/contracts/src/abstracts/AbstractPortalV2.sol
@@ -222,6 +222,16 @@ abstract contract AbstractPortalV2 is IPortal, ERC165 {
     uint256 value
   ) internal virtual {}
 
+  /**
+   * @notice Optional method run when attesting a batch of payloads
+   * @param attestationsPayloads the payloads to attest
+   * @param validationPayloads the payloads to validate in order to issue the attestations
+   */
+  function _onBulkAttest(
+    AttestationPayload[] memory attestationsPayloads,
+    bytes[][] memory validationPayloads
+  ) internal virtual {}
+
   /**
    * @notice Optional method run when an attestation is replaced
    * @dev    IMPORTANT NOTE: By default, replacement is only possible by the portal owner
@@ -237,16 +247,6 @@ abstract contract AbstractPortalV2 is IPortal, ERC165 {
     uint256 value
   ) internal virtual {}
 
-  /**
-   * @notice Optional method run when attesting a batch of payloads
-   * @param attestationsPayloads the payloads to attest
-   * @param validationPayloads the payloads to validate in order to issue the attestations
-   */
-  function _onBulkAttest(
-    AttestationPayload[] memory attestationsPayloads,
-    bytes[][] memory validationPayloads
-  ) internal virtual {}
-
   /**
    * @notice Optional method run when replacing a batch of payloads
    * @dev    IMPORTANT NOTE: By default, bulk replacement is only possible by the portal owner