fix: In a frontend setup, the SDK prompts a wallet popup as soon as it is loaded, before the dApp takes over #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainncls
requested review from
fdemiramon,
satyajeetkolhapure,
orbmis and
0xEillo
as code owners
alainncls
had a problem deploying
to
github-pages
GitHub Actions
Failure
alainncls
had a problem deploying
to
github-pages
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #424 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 18 18
Lines 309 309
Branches 68 68
=======================================
Hits 289 289
Misses 10 10
Partials 10 10 ☔ View full report in Codecov by Sentry. |
alainncls
force-pushed
the
fix/in-a-frontend-setup-the-sdk-prompts-a-wallet-popup-as-soon-as-it-is-loaded-before-the-dapp-takes-over
branch
from
40a5c61 to
aa0c72f
Compare
alainncls
had a problem deploying
to
github-pages
GitHub Actions
Failure
alainncls
force-pushed
the
fix/in-a-frontend-setup-the-sdk-prompts-a-wallet-popup-as-soon-as-it-is-loaded-before-the-dapp-takes-over
branch
from
aa0c72f to
cff7928
Compare
alainncls
had a problem deploying
to
github-pages
GitHub Actions
Failure
alainncls
had a problem deploying
to
github-pages
GitHub Actions
Failure
alainncls
had a problem deploying
to
github-pages
GitHub Actions
Failure
alainncls
temporarily deployed
to
github-pages
GitHub Actions
Inactive
alainncls
force-pushed
the
fix/in-a-frontend-setup-the-sdk-prompts-a-wallet-popup-as-soon-as-it-is-loaded-before-the-dapp-takes-over
branch
from
cff7928 to
1c6bad7
Compare
alainncls
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…t is loaded, before the dApp takes over
alainncls
force-pushed
the
fix/in-a-frontend-setup-the-sdk-prompts-a-wallet-popup-as-soon-as-it-is-loaded-before-the-dapp-takes-over
branch
from
1c6bad7 to
b00a8f1
Compare
orbmis
approved these changes
Nov 23, 2023
satyajeetkolhapure
approved these changes
Nov 23, 2023
alainncls
deleted the
fix/in-a-frontend-setup-the-sdk-prompts-a-wallet-popup-as-soon-as-it-is-loaded-before-the-dapp-takes-over
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the SDK integration in a frontend setup
Related ticket
Fixes #423
Type of change
Check list