feat: As a user, I want to differentiate the Attestations from each network #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainncls
requested review from
fdemiramon,
satyajeetkolhapure,
orbmis and
0xEillo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #427 +/- ##
==========================================
+ Coverage 93.52% 94.24% +0.72%
==========================================
Files 18 19 +1
Lines 309 313 +4
Branches 68 68
==========================================
+ Hits 289 295 +6
+ Misses 10 9 -1
+ Partials 10 9 -1 ☔ View full report in Codecov by Sentry. |
alainncls
force-pushed
the
feat/as-a-user-i-want-to-differentiate-the-attestations-from-each-network
branch
from
6e4e4ae to
7c399a9
Compare
alainncls
force-pushed
the
feat/as-a-user-i-want-to-differentiate-the-attestations-from-each-network
branch
from
7c399a9 to
ea8e0c1
Compare
orbmis
approved these changes
Nov 24, 2023
orbmis
reviewed
Nov 24, 2023
alainncls
force-pushed
the
feat/as-a-user-i-want-to-differentiate-the-attestations-from-each-network
branch
from
ea8e0c1 to
adbb81d
Compare
satyajeetkolhapure
approved these changes
Nov 24, 2023
0xEillo
reviewed
Nov 24, 2023
0xEillo
deleted the
feat/as-a-user-i-want-to-differentiate-the-attestations-from-each-network
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a "chain prefix" to differentiate the Attestations from multiple networks
Related ticket
Fixes #426
Type of change
Check list