Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: As a user, I want the SDK to check the transaction was validated before finishing a process #519

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat: As a user, I want the SDK to check the transaction was validated before finishing a process #519

merged 3 commits into from
Jan 11, 2024

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Jan 10, 2024 •
edited
Loading

What does this PR do?

Related ticket

Fixes #336

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@satyajeetkolhapure satyajeetkolhapure self-assigned this Jan 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

🚀 Deployed on https://65a014fee7dd68055ba5a608--resilient-starburst-d5d6d9.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 10, 2024 22:41 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1490ade) 93.63% compared to head (63b86d2) 93.63%.
Report is 10 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #519   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          20       20           
  Lines         330      330           
  Branches       76       76           
=======================================
  Hits          309      309           
  Misses         10       10           
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satyajeetkolhapure satyajeetkolhapure marked this pull request as ready for review January 11, 2024 11:21
@github-actions github-actions bot temporarily deployed to pull request January 11, 2024 11:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 11, 2024 16:19 Inactive
@satyajeetkolhapure satyajeetkolhapure merged commit add2afa into dev Jan 11, 2024
11 checks passed
@satyajeetkolhapure satyajeetkolhapure deleted the feat/as-a-user-i-want-the-SDK-to-check-the-transaction-was-validated-before-finishing-a-process branch January 11, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alainncls alainncls alainncls approved these changes

@orbmis orbmis Awaiting requested review from orbmis orbmis is a code owner

@0xEillo 0xEillo Awaiting requested review from 0xEillo

Assignees

@satyajeetkolhapure satyajeetkolhapure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want the SDK to check the transaction was validated before finishing a process
4 participants
@satyajeetkolhapure @codecov-commenter @alainncls @kolhapuresatyajeet