Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the type of the version field in Attestation at the SDK level #537

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: Fix the type of the version field in Attestation at the SDK level #537

merged 1 commit into from
Jan 18, 2024

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

Converts the version field of an attestation to a number
Deploys a new version of the SDK

Related ticket

Fixes #536

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Jan 17, 2024
@alainncls alainncls enabled auto-merge (squash) January 17, 2024 23:19
@alainncls alainncls force-pushed the fix/fix-the-type-of-the-version-field-in-attestation-at-the-sdk-level branch from 111173a to db7815e Compare January 17, 2024 23:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2024 •
edited
Loading

🚀 Deployed on https://65a947cddc57bf1f7a7658b6--resilient-starburst-d5d6d9.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 17, 2024 23:23 Inactive
@alainncls alainncls force-pushed the fix/fix-the-type-of-the-version-field-in-attestation-at-the-sdk-level branch from db7815e to 9afc763 Compare January 18, 2024 15:44
@github-actions github-actions bot temporarily deployed to pull request January 18, 2024 15:46 Inactive
@alainncls alainncls merged commit a18905f into dev Jan 18, 2024
11 checks passed
@alainncls alainncls deleted the fix/fix-the-type-of-the-version-field-in-attestation-at-the-sdk-level branch January 18, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbmis orbmis orbmis approved these changes

@satyajeetkolhapure satyajeetkolhapure Awaiting requested review from satyajeetkolhapure satyajeetkolhapure is a code owner

@0xEillo 0xEillo Awaiting requested review from 0xEillo

@ars9 ars9 Awaiting requested review from ars9

@Solniechniy Solniechniy Awaiting requested review from Solniechniy

Assignees

@alainncls alainncls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fix the type of the version field in Attestation at the SDK level
2 participants
@alainncls @orbmis