Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce the number of RPC calls when fetching attestations #580

Merged

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

When getting one or multiple attestation(s), the calls to fetch the Schema are now made to the subgraph instead of the chain. This reduces the number of RPC calls to 0 for such operations.

Related ticket

Fixes #579

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for verax-tutorial ready!

Name Link
🔨 Latest commit 1fd7b4b
🔍 Latest deploy log https://app.netlify.com/sites/verax-tutorial/deploys/6609b3704d374e00084798c2
😎 Deploy Preview https://deploy-preview-580--verax-tutorial.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request March 31, 2024 19:04 Inactive
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (f607329) to head (1fd7b4b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #580   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          20       20           
  Lines         330      330           
  Branches       76       76           
=======================================
  Hits          309      309           
  Misses         10       10           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls enabled auto-merge (squash) April 8, 2024 08:12
@alainncls alainncls merged commit 68b5be4 into dev Apr 8, 2024
16 checks passed
@alainncls alainncls deleted the fix/reduce-the-number-of-rpc-calls-when-fetching-attestations branch April 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reduce the number of RPC calls when fetching attestations
3 participants