-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): Add unit tests for the subgraph calls on the SDK #749
Merged
alainncls
merged 19 commits into
dev
from
chore/add-unit-tests-for-the-subgraph-calls-on-the-SDK
Oct 21, 2024
Merged
chore(sdk): Add unit tests for the subgraph calls on the SDK #749
alainncls
merged 19 commits into
dev
from
chore/add-unit-tests-for-the-subgraph-calls-on-the-SDK
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyajeetkolhapure
requested review from
alainncls,
orbmis and
arthur-remy
as code owners
October 14, 2024 16:34
@satyajeetkolhapure Can you add the unit tests files to the |
alainncls
requested changes
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #749 +/- ##
===========================================
- Coverage 92.07% 74.05% -18.02%
===========================================
Files 30 49 +19
Lines 492 902 +410
Branches 112 178 +66
===========================================
+ Hits 453 668 +215
- Misses 39 232 +193
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
alainncls
force-pushed
the
chore/add-unit-tests-for-the-subgraph-calls-on-the-SDK
branch
5 times, most recently
from
October 21, 2024 15:00
dbc820f
to
33d0170
Compare
alainncls
force-pushed
the
chore/add-unit-tests-for-the-subgraph-calls-on-the-SDK
branch
from
October 21, 2024 15:07
33d0170
to
980f6c5
Compare
alainncls
approved these changes
Oct 21, 2024
alainncls
deleted the
chore/add-unit-tests-for-the-subgraph-calls-on-the-SDK
branch
October 21, 2024 15:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unit tests are added in SDK for utils and base data mapper
Related ticket
Fixes #727
Type of change
Check list