Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Add unit tests for the subgraph calls on the SDK #749

Merged
merged 19 commits into from
Oct 21, 2024

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Oct 14, 2024

What does this PR do?

Unit tests are added in SDK for utils and base data mapper

Related ticket

Fixes #727

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls
Copy link
Collaborator

@satyajeetkolhapure Can you add the unit tests files to the .npmignore file? This will avoid packaging them with the released library.

sdk/package.json Outdated Show resolved Hide resolved
sdk/src/utils/abiCoder.test.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.05%. Comparing base (e99f776) to head (980f6c5).
Report is 34 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #749       +/-   ##
===========================================
- Coverage   92.07%   74.05%   -18.02%     
===========================================
  Files          30       49       +19     
  Lines         492      902      +410     
  Branches      112      178       +66     
===========================================
+ Hits          453      668      +215     
- Misses         39      232      +193     
- Partials        0        2        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls force-pushed the chore/add-unit-tests-for-the-subgraph-calls-on-the-SDK branch 5 times, most recently from dbc820f to 33d0170 Compare October 21, 2024 15:00
@alainncls alainncls force-pushed the chore/add-unit-tests-for-the-subgraph-calls-on-the-SDK branch from 33d0170 to 980f6c5 Compare October 21, 2024 15:07
@alainncls alainncls self-requested a review October 21, 2024 15:07
@alainncls alainncls merged commit de126c8 into dev Oct 21, 2024
9 checks passed
@alainncls alainncls deleted the chore/add-unit-tests-for-the-subgraph-calls-on-the-SDK branch October 21, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add unit tests for the subgraph calls on the SDK
3 participants