-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(contracts)(sdk): Optimize gas efficiency when fetching a Portal #838
chore(contracts)(sdk): Optimize gas efficiency when fetching a Portal #838
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #838 +/- ##
===========================================
+ Coverage 48.84% 74.43% +25.59%
===========================================
Files 18 51 +33
Lines 389 888 +499
Branches 63 183 +120
===========================================
+ Hits 190 661 +471
- Misses 196 224 +28
Partials 3 3 ☔ View full report in Codecov by Sentry. |
d0157dd
to
5a8372f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B
getPortalRevocability(0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B) -> bool
|
getPortalOwner(0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B) -> address |
What does this PR do?
To optimize gas efficiency 2 functions are added in portal registry along with
getPortalByAddress
Related ticket
Fixes #809
Type of change
Check list