Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts)(sdk): Optimize gas efficiency when fetching a Portal #838

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Nov 28, 2024

What does this PR do?

To optimize gas efficiency 2 functions are added in portal registry along with getPortalByAddress

getPortalOwner(address portalAddress) -> address
getPortalRevocability(address portalAddress) -> bool

Related ticket

Fixes #809

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.43%. Comparing base (874a467) to head (c63b6ac).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
sdk/src/dataMapper/PortalDataMapper.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #838       +/-   ##
===========================================
+ Coverage   48.84%   74.43%   +25.59%     
===========================================
  Files          18       51       +33     
  Lines         389      888      +499     
  Branches       63      183      +120     
===========================================
+ Hits          190      661      +471     
- Misses        196      224       +28     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satyajeetkolhapure satyajeetkolhapure force-pushed the chore/optimize-gas-efficiency-when-fetching-a-portal branch from d0157dd to 5a8372f Compare November 28, 2024 11:24
@alainncls alainncls merged commit bc9809b into dev Nov 28, 2024
9 checks passed
@alainncls alainncls deleted the chore/optimize-gas-efficiency-when-fetching-a-portal branch November 28, 2024 13:12
Copy link

@Nopandi1101 Nopandi1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B

@Nopandi1101
Copy link

Apa fungsi PR ini?

Untuk mengoptimalkan efisiensi gas, 2 fungsi ditambahkan di registri portal bersama dengangetPortalByAddress

getPortalOwner(0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B) -> address

getPortalRevocability(0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B) -> bool

getPortalOwner(0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B) -> address
getPortalRevocability(0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B) -> bool


### Tiket terkait
Perbaikan #809

### Jenis perubahan
* [x] Pekerjaan rumah
* [ ] Perbaikan bug
* [ ] Fitur baru
* [ ] Pembaruan dokumentasi

## Daftar periksa
* [x] Pengujian unit untuk setiap perubahan kontrak pintar
* [ ] Kontrak dan fungsi didokumentasikan

@Nopandi1101
Copy link

getPortalOwner(0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B) -> address
getPortalRevocability(0xF1CA31083E0c073779C8D5ACA3F1bB3b4CBB558B) -> bool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Optimize gas efficiency when fetching a Portal
4 participants