Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): As a user, I want the Portal page to display links to the Portal contract and owner addresses #849

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Chirag-S-Kotian
Copy link
Contributor

@Chirag-S-Kotian Chirag-S-Kotian commented Dec 2, 2024

What does this PR do?

Description

Enhances the Portal page by converting static addresses into clickable blockchain explorer links, improving user experience and accessibility.

Changes

  • Added clickable blockchain explorer links for Portal contract address
  • Added clickable blockchain explorer links for Portal owner address
  • Integrated external link indicators using ArrowUpRight icon
  • Preserved ENS name display functionality for owner addresses
  • Maintained consistent styling with the existing UI

Implementation Details

  • Utilized getBlockExplorerLink utility to generate network-specific explorer URLs
  • Added conditional link rendering based on chain availability
  • Implemented external link styling with hover effects
  • Added visual indicators for external links

Testing

  • Verified links work correctly across different networks
  • Confirmed ENS name display remains functional
  • Tested fallback behavior when chain explorer is unavailable

Related ticket

Fixes #782

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls changed the title As a user, I want the Portal page to display links to the Portal contract and owner addresses feat(explorer): As a user, I want the Portal page to display links to the Portal contract and owner addresses Dec 2, 2024
@alainncls alainncls merged commit 0dcb079 into Consensys:dev Dec 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want the Portal page to display links to the Portal contract and owner addresses
2 participants