Merge pull request #144 from ConsenSys/writer.literal.nit

Normalize value in string literals to null when undefined
Consensys · Aug 10, 2022 · c0cd987 · c0cd987
2 parents 1cfbd1f + f726a46
commit c0cd987
Show file tree

Hide file tree

Showing 6 changed files with 186 additions and 184 deletions.
diff --git a/src/ast/modern/literal_processor.ts b/src/ast/modern/literal_processor.ts
@@ -13,7 +13,7 @@ export class ModernLiteralProcessor extends ModernExpressionProcessor<Literal> {
 
         const kind: LiteralKind = raw.kind;
         const hexValue: string = raw.hexValue;
-        const value: string = raw.value;
+        const value: string = raw.value === undefined ? null : raw.value;
         const subdenomination: TimeUnit | EtherUnit | undefined = raw.subdenomination
             ? raw.subdenomination
             : undefined;

diff --git a/test/integration/compile/latest_08.spec.ts b/test/integration/compile/latest_08.spec.ts
@@ -117,7 +117,7 @@ for (const compilerKind of PossibleCompilerKinds) {
             // console.log(sourceUnit.getChildren().length);
 
             expect(sourceUnit.id).toEqual(738);
-            expect(sourceUnit.src).toEqual("0:8593:0");
+            expect(sourceUnit.src).toEqual("0:8621:0");
             expect(sourceUnit.absolutePath).toEqual(mainSample);
             expect(sourceUnit.children.length).toEqual(30);
             expect(sourceUnit.getChildren().length).toEqual(731);