Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add StarkScan client to fetch transaction history #341

Merged
merged 25 commits into from
Dec 5, 2024
Merged

feat: add StarkScan client to fetch transaction history #341

merged 25 commits into from
Dec 5, 2024

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Sep 2, 2024 •
edited
Loading

This PR is adding a client sdk to fetch the transaction history with StarkScan

This is the first journey to enable fetching transaction by StarkScan

This PR includes:

  • a starkscan data client to enable:
    • getTransactions (by address , by till to timestamp)
    • getDeployTransaction (by address)
  • a dataClient interface IDataClient for generic interface
  • a factory to create the StarkScanClient
  • a config mapping for StarkScanClient

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner September 2, 2024 07:12
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and wantedsystem and removed request for a team September 2, 2024 07:12
@stanleyyconsensys stanleyyconsensys mentioned this pull request Sep 5, 2024
Closed
1 task
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys changed the title feat: add StarkScan client to fetch transaction history feat(StarkScan): add StarkScan client to fetch transaction history Oct 8, 2024
@stanleyyconsensys stanleyyconsensys changed the title feat(StarkScan): add StarkScan client to fetch transaction history feat(SNAP): add StarkScan client to fetch transaction history Oct 22, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys marked this pull request as draft October 22, 2024 09:45
@stanleyyconsensys stanleyyconsensys self-assigned this Dec 2, 2024
@stanleyyconsensys stanleyyconsensys marked this pull request as ready for review December 2, 2024 07:56
@stanleyyconsensys stanleyyconsensys marked this pull request as draft December 2, 2024 07:58
@stanleyyconsensys stanleyyconsensys marked this pull request as ready for review December 2, 2024 09:11
@stanleyyconsensys stanleyyconsensys changed the title feat(SNAP): add StarkScan client to fetch transaction history feat: add StarkScan client to fetch transaction history Dec 2, 2024
khanti42
khanti42 requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarifying comments

packages/starknet-snap/src/__tests__/helper.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/chain/data-client/starkscan.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/chain/data-client/starkscan.ts Show resolved Hide resolved
packages/starknet-snap/src/types/snapState.ts Outdated Show resolved Hide resolved
packages/starknet-snap/snap.config.ts Show resolved Hide resolved
packages/starknet-snap/src/chain/data-client/starkscan.ts Outdated Show resolved Hide resolved
@stanleyyconsensys stanleyyconsensys mentioned this pull request Dec 5, 2024
Merged
1 task
khanti42
khanti42 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanti42 khanti42 enabled auto-merge December 5, 2024 07:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
4.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khanti42 khanti42 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit cfdc79d Dec 5, 2024
14 checks passed
@khanti42 khanti42 deleted the feat/add-stark-scan-client branch December 5, 2024 07:34
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanti42 khanti42 khanti42 approved these changes

@Julink-eth Julink-eth Awaiting requested review from Julink-eth Julink-eth is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@wantedsystem wantedsystem Awaiting requested review from wantedsystem wantedsystem is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees

@stanleyyconsensys stanleyyconsensys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @khanti42