-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: two steps CI CD deployment #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some ENV setup incorrect
and i would suggest keep this 2 new pipeline for production only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some remove of cache key, but not sure does it work, needed to test
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
Why This Change?
Goal
To safely test new snap versions in production (e.g. on MetaMask not MetaMask Flask) before forcing updates on end-users:
The new workflow would be
Solution
Split the workflow into two parts:
Publish NPM:
starknet-snap
.Deploy UI and Get Starknet:
wallet-ui
andget-starknet
separately after snap validation.Known Limitations
get-starknet
Wildcard Behavior:*
).Benefits
get-starknet
users.