Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update test for UserInputEventController #436

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore: update test for UserInputEventController #436

merged 2 commits into from
Nov 25, 2024

Conversation

stanleyyconsensys
Copy link
Collaborator

This PR is to update the test in UserInputEventController

and it also fixing the bug in generate errorMessage

  • it was using the selectedFeeToken from the updated request, but the request may change, it was passed because the test is not correct
  • it using the selectedFeeToken from the original request, and adding a test to make sure both token not same

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner November 25, 2024 13:46
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and wantedsystem and removed request for a team November 25, 2024 13:46
khanti42
khanti42 previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khanti42 khanti42 self-requested a review November 25, 2024 13:58
khanti42
khanti42 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanti42 khanti42 added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit ffaeb1b Nov 25, 2024
13 checks passed
@khanti42 khanti42 deleted the chore/update-select-fee-token-test branch November 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanti42 khanti42 khanti42 approved these changes

@Julink-eth Julink-eth Awaiting requested review from Julink-eth Julink-eth is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@wantedsystem wantedsystem Awaiting requested review from wantedsystem wantedsystem is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @khanti42