Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cicd split pipeline for production #438

Merged
merged 6 commits into from
Nov 26, 2024
Merged

chore: cicd split pipeline for production #438

merged 6 commits into from
Nov 26, 2024

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Nov 25, 2024

BEGIN_COMMIT_OVERRIDE

chore: cicd split pipeline for production
END_COMMIT_OVERRIDE

@khanti42 khanti42 requested a review from a team as a code owner November 25, 2024 23:51
@khanti42 khanti42 requested review from Julink-eth and jonesho and removed request for a team November 25, 2024 23:51
@khanti42 khanti42 changed the title chore: CI CD split pipeline enabled dev and prod chore: ci cd split pipeline enabled dev and prod Nov 25, 2024
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 minor comment

.github/workflows/deploy-wallet-get-starknet.yml Outdated Show resolved Hide resolved
@khanti42 khanti42 enabled auto-merge November 26, 2024 15:01
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khanti42 khanti42 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 4ee8763 Nov 26, 2024
13 checks passed
@khanti42 khanti42 deleted the dev-ci-cd-split branch November 26, 2024 15:16
@stanleyyconsensys stanleyyconsensys changed the title chore: ci cd split pipeline enabled dev and prod chore: cicd split pipeline for production Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants