Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace RPC provider from Alchemy to Infura DIN #451

Merged
merged 15 commits into from
Dec 19, 2024
Merged

feat: replace RPC provider from Alchemy to Infura DIN #451

merged 15 commits into from
Dec 19, 2024

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Dec 5, 2024 •
edited by stanleyyconsensys
Loading

This PR is to replace the Alchemy RPC provider by Infura DIN one.

The required changes in the CI/CD workflow will happen elsewhere.

BEGIN_COMMIT_OVERRIDE
feat: Replace RPC provider from Alchemy to Infura DIN (#451)
END_COMMIT_OVERRIDE

@khanti42 khanti42 requested a review from a team as a code owner December 5, 2024 11:53
@khanti42 khanti42 requested review from Akaryatrh and stanleyyconsensys and removed request for a team December 5, 2024 11:53
stanleyyconsensys
stanleyyconsensys reviewed Dec 6, 2024
View reviewed changes
packages/starknet-snap/package.json Show resolved Hide resolved
packages/starknet-snap/src/utils/din.test.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/din.ts Outdated Show resolved Hide resolved
stanleyyconsensys
stanleyyconsensys reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just 1 nit comment

packages/starknet-snap/src/utils/rpc-provider.test.ts Outdated Show resolved Hide resolved
@stanleyyconsensys stanleyyconsensys changed the title feat: replace alchemy by infura din feat: replace RPC provider from Alchemy to Infura DIN Dec 11, 2024
stanleyyconsensys
stanleyyconsensys reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a nit change and a doc update

packages/starknet-snap/src/utils/rpc-provider.test.ts Show resolved Hide resolved
packages/starknet-snap/src/utils/rpc-provider.ts Show resolved Hide resolved
@khanti42 khanti42 enabled auto-merge December 18, 2024 14:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
29.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khanti42 khanti42 added this pull request to the merge queue Dec 18, 2024
@khanti42 khanti42 removed this pull request from the merge queue due to a manual request Dec 18, 2024
@khanti42 khanti42 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit eb6c688 Dec 19, 2024
14 checks passed
@khanti42 khanti42 deleted the feat/sf-703 branch December 19, 2024 09:26
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
@khanti42 khanti42 mentioned this pull request Jan 6, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleyyconsensys stanleyyconsensys stanleyyconsensys approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanti42 @stanleyyconsensys