Implemented should_override_fork_choice for late block reorg #7763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented should_override_fork_choice function, and tested results via the reftests. There's a level of duplication in the 'should_override_fork_choice' and 'get_proposer_head', but I've stayed true to the spec, while fixing ordering a little to do cheaper tests first. Ultimately, the function will exit fast once it finds a mis-match, and if it gets to the end then things pass. Also had to adjust timeliness to use store time, and I made the Store implement the TimeProvider to fix an issue with using a system time provider when store time was needed. Finally, while I did successfully run the reftests, I have to leave the reftests disabled until we get a release that doesnt contain backwards ticks. It's possible to remove the ticks to run the tests, but they won't run out of the box. partially addresses Consensys#6595 Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
...n/src/main/java/tech/pegasys/teku/services/beaconchain/ValidatorIsConenctedProviderImpl.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/tech/pegasys/teku/storage/client/RecentChainData.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/tech/pegasys/teku/storage/client/RecentChainData.java
Show resolved
Hide resolved
Signed-off-by: Paul Harris <paul.harris@consensys.net>
lucassaldanha
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented should_override_fork_choice function, and tested results via the reftests.
There's a level of duplication in the 'should_override_fork_choice' and 'get_proposer_head', but I've stayed true to the spec, while fixing ordering a little to do cheaper tests first.
Ultimately, the function will exit fast once it finds a mis-match, and if it gets to the end then things pass.
Also had to adjust timeliness to use store time, and I made the Store implement the TimeProvider to fix an issue with using a system time provider when store time was needed.
Finally, while I did successfully run the reftests, I have to leave the reftests disabled until we get a release that doesnt contain backwards ticks. It's possible to remove the ticks to run the tests, but they won't run out of the box.
partially addresses #6595
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog