fix accidental cache bypass if balance==0

Consensys · Nov 23, 2021 · bd45998 · bd45998
1 parent c1b8332
commit bd45998
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/features/hover.js b/src/features/hover.js
@@ -128,7 +128,8 @@ async function provideBalanceHover(document, position, token) {
         //cconf.name, enabled
 
         try {
-            if(!balance){
+
+            if(balance === undefined){
                 let etherscan = new EtherScanIo(cconf.apiKey, cconf.apiurl);
                 balance = await etherscan.balanceForAddress(address);
                 //balance = await etherscan.api.account.balance(address); //etherscanapi does not support custom chains

diff --git a/src/features/utils.js b/src/features/utils.js
@@ -23,7 +23,7 @@ class TimeoutCache {
     }
 
     get(prefix, key, def){
-        return this.data[`${prefix}+${key}`] || def;
+        return this.data[`${prefix}+${key}`] !== undefined ? this.data[`${prefix}+${key}`] : def;
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,7 @@ class TimeoutCache { @@
         }
         get(prefix, key, def){
-            return this.data[`${prefix}+${key}`] || def;
+            return this.data[`${prefix}+${key}`] !== undefined ? this.data[`${prefix}+${key}`] : def;
         }
     }
@@ Expand Down @@