Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor eth1 and eth2 routes #1028

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

usmansaleem
Copy link
Contributor

PR Description

feat: Refactor eth1 and eth2 routes to separate classes to declutter Eth1Runner and Eth2Runner populateRoute methods.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

 -- refactor routes to separate classes to declutter Eth1Runner and Eth2Runner populateRoute methods
@usmansaleem usmansaleem marked this pull request as draft October 17, 2024 00:03
@usmansaleem usmansaleem marked this pull request as ready for review October 17, 2024 00:25
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code is much cleaner after this change

@usmansaleem usmansaleem merged commit 9335457 into Consensys:master Oct 17, 2024
6 checks passed
@usmansaleem usmansaleem deleted the refactor_routes branch October 17, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants