Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Signers bls-keystore library with Teku bls-keystore #879

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Replace Signers bls-keystore library with Teku bls-keystore #879

merged 1 commit into from
Aug 17, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Aug 17, 2023 •
edited
Loading

PR Description

Replace Signers bls-keystore library with Teku bls-keystore

Fixed Issue(s)

fixes #875

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

usmansaleem
usmansaleem approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe merged commit 331019e into Consensys:master Aug 17, 2023
2 checks passed
@jframe jframe deleted the teku_bls_keystore branch August 17, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use BLS keystore from Teku
2 participants
@jframe @usmansaleem