Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support signing_root in Eth2 Signing request body #880

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Support signing_root in Eth2 Signing request body #880

merged 6 commits into from
Aug 18, 2023

Conversation

usmansaleem
Copy link
Contributor

PR Description

Support signing_root in Eth2 Signing Request body. Add @JsonAlias to allow supporting both signing_root and signingRoot in incoming signing requst body.

Also update errorprone to support Java 17 language constructs.

Fixed Issue(s)

#458

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

jframe
jframe approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem enabled auto-merge (squash) August 18, 2023 03:36
@usmansaleem usmansaleem merged commit ababf26 into Consensys:master Aug 18, 2023
2 checks passed
@usmansaleem usmansaleem deleted the support_signing_root_json branch September 6, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmansaleem @jframe