Skip to content

Commit

Permalink
when retrieving data from an inbuffer, no longer restrict ourselves t…
Browse files Browse the repository at this point in the history
…o uint32
  • Loading branch information
EmielBruijntjes committed Apr 25, 2022
1 parent edd0bb7 commit 328d9d1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion include/amqpcpp/inbuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class InBuffer
* @param size
* @return char*
*/
const char *nextData(uint32_t size);
const char *nextData(size_t size);

/**
* The checker may access private data
Expand Down
2 changes: 1 addition & 1 deletion src/inbuffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ double InBuffer::nextDouble()
* @param size
* @return char*
*/
const char *InBuffer::nextData(uint32_t size)
const char *InBuffer::nextData(size_t size)
{
// check if there is enough size
BufferCheck check(this, size);
Expand Down

1 comment on commit 328d9d1

@SebDieBln
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still a subtle bug because _skip remains a uint32_t and thus InBuffer is not yet fully compatible with data chunks larger than 2 GB? See my PR #462 for a possible solution.

Please sign in to comment.