feat: Better reply support (#418)

[jawoznia]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 81.85185% with 147 lines in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (10e8eb9) to head (4f09075).

Files with missing lines	Patch %	Lines
sylvia-derive/src/contract/communication/reply.rs	90.41%	32 Missing ⚠️
sylvia/tests/reply_generation.rs	0.00%	14 Missing ⚠️
sylvia/src/builder/instantiate.rs	47.82%	12 Missing ⚠️
sylvia-derive/src/parser/attributes/msg.rs	78.43%	11 Missing ⚠️
sylvia/src/ctx.rs	35.29%	11 Missing ⚠️
sylvia-derive/src/parser/attributes/data.rs	62.96%	10 Missing ⚠️
sylvia-derive/src/entry_points.rs	0.00%	8 Missing ⚠️
sylvia-derive/src/parser/attributes/payload.rs	50.00%	8 Missing ⚠️
sylvia/tests/remote.rs	63.63%	8 Missing ⚠️
sylvia/tests/reply_dispatch.rs	91.35%	7 Missing ⚠️
... and 9 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   70.08%   72.37%   +2.29%     
==========================================
  Files          53       63      +10     
  Lines        3085     3823     +738     
==========================================
+ Hits         2162     2767     +605     
- Misses        923     1056     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kulikthebird]

Replies are part of a mechanism that is not trivial for non-sylvia developers. Handling them in sylvia is a huge milestone for this crate and this should make it more useful for sylvia devs. That's a great work done and pretty complex issue solved here! Since the final PR combines all of the partial work checked already in other PRs, I'm not that worried about the details here. I left some clean-up related comments that we should consider before merging it to the main branch. Thank you for this implementation, well done!

[kulikthebird]

I see that sylvia prints reply data. What would happen if the msg content size is for e.g. 1MB?

[kulikthebird]

Just one more question. What would happen if we implement such a reply:

#[sv::msg(reply, reply_on=success)]
    fn some_reply(
        &self,
        _ctx: ReplyCtx,
        #[sv::data] _data: ComplexData,
        #[sv::payload(raw)] _payload: Binary,
        some_custom_arg: String    // We provide sv::payload(raw) and a custom arg
    ) -> Result<Response, ContractError> {
        Ok(Response::new())
    }

[jawoznia]

Just one more question. What would happen if we implement such a reply:

#[sv::msg(reply, reply_on=success)]
    fn some_reply(
        &self,
        _ctx: ReplyCtx,
        #[sv::data] _data: ComplexData,
        #[sv::payload(raw)] _payload: Binary,
        some_custom_arg: String    // We provide sv::payload(raw) and a custom arg
    ) -> Result<Response, ContractError> {
        Ok(Response::new())
    }

Good question. I haven't thought about that. I will check