Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ngc #684

Closed
wants to merge 26 commits into from
Closed

Ngc #684

wants to merge 26 commits into from

Conversation

martinkilbinger
Copy link
Contributor

Summary

Developers should provide a summary of the proposed changes here and include "closes #" if this addresses an open issue.

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

martinkilbinger and others added 26 commits June 22, 2022 16:38
@martinkilbinger
added masking for NGC objects
497d604
@martinkilbinger
debugging ngc np binary file
7abd0c3
@martinkilbinger
Fixed bugs in new mask handling (input FITS files)
4fc3c21
@martinkilbinger
debug info to log file for checking existing images
f97c937
@martinkilbinger
mask: combined dso masks into dictionary
0f6de15
@martinkilbinger
PR edits
2ea46d4
@martinkilbinger @sfarrens
Update shapepipe/modules/mask_package/mask.py
812e841 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/modules/mask_package/mask.py
98b8c25 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/modules/mask_package/mask.py
a24e2dc 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/modules/mask_package/mask.py
6283f6a 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger
added symlink
5d97cce
@martinkilbinger @sfarrens
Update shapepipe/pipeline/file_io.py
5d44417 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/modules/mask_package/mask.py
635fbe4 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/pipeline/file_io.py
6bddb1f 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/pipeline/file_io.py
d51f81e 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/pipeline/file_io.py
b3949fa 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/pipeline/file_io.py
eff9b6c 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger
Merge remote-tracking branch 'upstream/develop' into ngc
9d67abd
@martinkilbinger @sfarrens
Update shapepipe/modules/mask_package/mask.py
a27e19c 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/modules/mask_package/mask.py
5b24439 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/modules/mask_package/mask.py
d0c6f2a 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger @sfarrens
Update shapepipe/pipeline/file_io.py
baf372f 
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
@martinkilbinger
PR suggestions
84f991a
@martinkilbinger
Fixed html link
74a8ca1
@martinkilbinger
Merge remote-tracking branch 'upstream/develop' into ngc
3ec1b97 
Conflicts:
	shapepipe/modules/mask_package/__init__.py
	shapepipe/modules/mask_package/mask.py
@martinkilbinger
Merge branch 'CosmoStat:develop' into ngc
9a8738f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinkilbinger