Feat : added unit tests to project #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyeleke
requested review from
helios66,
goke-epapa,
JubrilEdu,
codedentwickler,
beccadaniel and
JohnItoo
goke-epapa
suggested changes
May 28, 2018
app/build.gradle
Outdated
| } | ||
|
|
||
| dependencies { | ||
| compile fileTree(dir: 'libs', include: ['*.jar']) |
There was a problem hiding this comment.
app/build.gradle
Outdated
| compile 'com.jakewharton:butterknife:8.8.1' | ||
| annotationProcessor 'com.google.dagger:dagger-compiler:2.10' | ||
| androidTestCompile 'com.android.support.test:runner:1.0.2' | ||
| testCompile 'org.mockito:mockito-core:2.7.22' |
There was a problem hiding this comment.
Change testCompile to testImplementation
app/build.gradle
Outdated
| annotationProcessor 'com.google.dagger:dagger-compiler:2.10' | ||
| androidTestCompile 'com.android.support.test:runner:1.0.2' | ||
| testCompile 'org.mockito:mockito-core:2.7.22' | ||
| androidTestCompile 'org.mockito:mockito-android:2.7.22' |
There was a problem hiding this comment.
You'll need to change this as well, confirm what the newer keyword is.
| // Context of the app under test. | ||
| Context appContext = InstrumentationRegistry.getTargetContext(); | ||
|
|
||
| assertEquals("com.example.oyeleke.rxjavatest", appContext.getPackageName()); |
|
|
||
| //test to ensure that when a null user value is changed no interaction takes place in the view | ||
| // @Test | ||
| // public void noInteractionWithView(){ |
| //verify model interactions | ||
| verify(mockLoginModel, times(1)).getUser(); | ||
| //test fails if the model is called more than once | ||
| // verify(mockLoginModel, times(2)).getUser(); |
JubrilEdu
reviewed
May 28, 2018
.gitignore
Outdated
| .gradle | ||
| /local.properties | ||
| /.idea/workspace.xml | ||
| /.idea/libraries |
app/build.gradle
Outdated
| android { | ||
| compileSdkVersion 27 | ||
| defaultConfig { | ||
| applicationId "com.example.oyeleke.rxjavatest" |
There was a problem hiding this comment.
I think you should change the applicationID
| @@ -0,0 +1,23 @@ | |||
| package com.example.oyeleke.dependencyinjectionandtestdemo.login; | |||
|
|
|||
| /** | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests by mocking objects using mockito,