This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
Configureable Restricted Areas #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #870 by replacing the hard coded RESTRICTED_AREA object and instead using the restrictedAreas variable in the counterwallet.conf.json file, making the code work the way that documentation states.
Came across this issue when trying to configure my federated node per the documentation and finding that the configuration value I set did not take effect as expected.
One issue I had was making restrictedAreas work like disabledFeatures, as an observableArray, so if there is a better way to do this, please suggest how to refactor, maybe because its an object and not an array, but this code works as expected functionality-wise when I test it.