Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold tool (create-component) #129

Merged
merged 16 commits into from
Jan 18, 2018
Merged

Scaffold tool (create-component) #129

merged 16 commits into from
Jan 18, 2018

Conversation

fczuardi
Copy link
Contributor

@fczuardi fczuardi commented Nov 27, 2017 •
edited
Loading

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fa5a3fb on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bb4064d on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling acad0c6 on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d6cc179 on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 27a4be7 on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b63f274 on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling db19fd0 on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling cc81c51 on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 498e024 on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7b0171e on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ecec095 on feature/scaffold into ** on master**.

@fczuardi fczuardi force-pushed the feature/scaffold branch 2 times, most recently from d2ed567 to 923ccab Compare December 11, 2017 20:52
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 923ccab on feature/scaffold into ** on master**.

@fczuardi fczuardi changed the title [WIP] Feature/scaffold Feature/scaffold Dec 12, 2017
@fczuardi fczuardi changed the title Feature/scaffold [WIP] Feature/scaffold Dec 12, 2017
@fczuardi
Copy link
Contributor Author

forgot to add the npm task, going back to [wip]

@fczuardi
Copy link
Contributor Author

also, snyk failed with two security concerns, kinda of expected in the case of the shelljs dependency, that have the purpose of executing shell commands, but might need some digging on the current github discussions of each project (and might be possible to replace with less powerful tools) so I will keep this on hold for a little longer

@fczuardi fczuardi added the blocked Waiting for someone, for definition, for more info, or depends on another issue label Dec 21, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1b14d97 on feature/scaffold into ** on master**.

@fczuardi fczuardi mentioned this pull request Jan 17, 2018
Open
@fczuardi
Copy link
Contributor Author

I have opened issue #213 to keep track of the exceptions I am about to add in the snyk policy file, and to allow us to unblock this PR

fczuardi added 12 commits January 18, 2018 11:17
@fczuardi
feat(package.json): initial package.json with script to create component
42b2b89 
affects: @crave/farmblocks-dev-scaffold

squash! feat(package.json): initial package.json with script to create component
@fczuardi
feat(templates): package and readme templates
d49afc4 
affects: @crave/farmblocks-dev-scaffold
@fczuardi
feat(scaffold): main script to create a package folder
a8c4669 
affects: @crave/farmblocks-dev-scaffold

include the initial files, package, readme, and a copy of the root AUTHORS file

ISSUES CLOSED: #128

create component

create component
@fczuardi
test(eslint): add node_modules on ingnored files lists
e12211d
@fczuardi
refactor(templates): create a folder to all templates
419b33f 
affects: @crave/farmblocks-dev-scaffold
@fczuardi
feat(templates): add basic index.js and main component file templates
c05ca93 
affects: @crave/farmblocks-dev-scaffold
@fczuardi
feat(templates): storybook stories initial file template
fbdf314 
affects: @crave/farmblocks-dev-scaffold
@fczuardi
chore(lockfile): update
1393b7d
@fczuardi
chore(dependencies): update shelljs version
6b073be 
affects: @crave/farmblocks-dev-scaffold
@fczuardi
docs(snyk): ignore two vulnerabilities for 4 months
a39fbe7
@fczuardi
feat(scaffold): include a build script to bootstrap new farmblocks co…
b47094e 
…mponents

add dev-scaffold tool as a dev dependency of the root and include a npm script create-component to
use it
@fczuardi
docs(contibuting): included section about how to start a new component
5696eec
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5696eec on feature/scaffold into ** on master**.

alcferreira
alcferreira reviewed Jan 18, 2018
View reviewed changes
Copy link
Contributor

@alcferreira alcferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks great! 🥇

packages/scaffold/package.json Outdated
"name": "@crave/farmblocks-dev-scaffold",
"version": "0.1.0",
"description": "Helper tool for creating a new farmblock component",
"author": "Crave Food Services and AUTHORS",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Crave Food Systems and AUTHORS

packages/scaffold/src/templates/package.js Outdated
"name": "@crave/farmblocks-${shortName}",
"version": "0.1.0",
"description": "${description}",
"author": "Crave Food Services and AUTHORS",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Crave Food Systems and AUTHORS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1c8fea8 on feature/scaffold into 6f8db0f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2ddd860 on feature/scaffold into 522f55f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2ddd860 on feature/scaffold into 522f55f on master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c94904d on feature/scaffold into ** on master**.

@fczuardi
Copy link
Contributor Author

change requests addressed

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling edebbeb on feature/scaffold into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6223518 on feature/scaffold into ** on master**.

@alcferreira alcferreira merged commit a0baa42 into master Jan 18, 2018
@alcferreira alcferreira deleted the feature/scaffold branch January 18, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcferreira alcferreira alcferreira approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build task to scaffold a new component
3 participants
@fczuardi @coveralls @alcferreira