CID Command Line Option for MSSP Auth Backend #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status quo is that you have to search for the CID you are working with every time you launch the Toolkit if you are an MSSP customer. This change allows you to specify the CID in either an environment variable or as a command line option (
--cid).This change is also available generically to other auth backends should they be available in the future.
Additionally, by passing the Click Context through to the
authenticate()function, we pave the way for other parameters to be passed through to authentication backends in the future if required.Note that we have a breaking change here. The only supported environment variable to set the CID for an auth backend that supports it (like the MSSP one) will be
FALCON_TOOLKIT_CID. The other (FALCON_MSSP_CHILD_CID) has been removed, since it wasn't consistent and the new one is simpler and generalised. Apologies for any inconvenience caused.