EP-2517 Branded Checkout Improvements #1117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrandall22
reviewed
Nov 20, 2024
| <branded-checkout designation-number="2294554" show-cover-fees="true" ng-cloak></branded-checkout> | ||
| <script src="branded-checkout.v2.js"></script> | ||
| <branded-checkout designation-number="2294554" show-cover-fees="true" use-v3="true" ng-cloak></branded-checkout> | ||
| <script src="dev.v2.js"></script> |
There was a problem hiding this comment.
We'll want to change this back before we merge.
There was a problem hiding this comment.
Was there mention of JSON config file for these options or did I make that up? Are we just using the use-v3 flag for everything?
There was a problem hiding this comment.
There is no config file, we use this flag for everything.
wrandall22
reviewed
Nov 20, 2024
|
Thanks for getting this set up! |
caleballdrin
force-pushed
the
EP-2517-branded-checkout-improvements
branch
from
46718e5
to
874f3fd
Compare
|
@wjames111 You can make your feature branches off of this one. |
|
Reminder to fix lint issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base branch with
use-v3config option.