Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Static Banner #799

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Static Banner #799

wants to merge 11 commits into from

Conversation

caleballdrin
Copy link
Contributor

Description

Add notification so many users know they need to move out of MPDX
https://jira.cru.org/browse/MPDX-7790

Changes Made

  • Add StaticBanner Component
  • Banner shows based on env variable
  • Within the Static Banner component it will show based on future API response
  • Attempted to add tests based on env variable.

@caleballdrin caleballdrin requested a review from dr-bizz October 23, 2023 20:44
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-799.d3dytjb8adxkk5.amplifyapp.com

src/components/Shared/staticBanner/StaticBanner.tsx Outdated Show resolved Hide resolved
src/components/Shared/staticBanner/StaticBanner.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Dashboard.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Dashboard.tsx Outdated Show resolved Hide resolved
@caleballdrin caleballdrin requested a review from dr-bizz October 25, 2023 15:07
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Still needs a few changes

src/components/Shared/staticBanner/StaticBanner.tsx Outdated Show resolved Hide resolved
src/components/Shared/staticBanner/StaticBanner.tsx Outdated Show resolved Hide resolved
src/components/Shared/staticBanner/StaticBanner.test.tsx Outdated Show resolved Hide resolved
@caleballdrin caleballdrin requested a review from dr-bizz October 31, 2023 19:44
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. Just need to update ReadMe.

next.config.js Show resolved Hide resolved
@caleballdrin caleballdrin requested review from canac and dr-bizz November 8, 2023 18:39
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great and works locally! I just had a couple of suggestions for simplifying the tests.

src/components/Shared/staticBanner/StaticBanner.test.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Dashboard.test.tsx Show resolved Hide resolved
@canac
Copy link
Contributor

canac commented Nov 8, 2023

Is the query you're using in production yet? That might be the source of the GHA failures.

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once https://github.com/CruGlobal/mpdx_api/pull/2728 is merged, the tests will hopefully pass and this will be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants