-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Static Banner #799
base: main
Are you sure you want to change the base?
Add Static Banner #799
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Still needs a few changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great. Just need to update ReadMe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great and works locally! I just had a couple of suggestions for simplifying the tests.
Is the query you're using in production yet? That might be the source of the GHA failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once https://github.com/CruGlobal/mpdx_api/pull/2728 is merged, the tests will hopefully pass and this will be good to go!
Description
Add notification so many users know they need to move out of MPDX
https://jira.cru.org/browse/MPDX-7790
Changes Made