Skip to content

Commit

Permalink
Remove flakey tests
Browse files Browse the repository at this point in the history
These tests are flaky or unused.
Removing them from testing pipelines.
We need to refactor them so that they run more consistently
  • Loading branch information
jmckulk committed Dec 6, 2024
1 parent 1a009c2 commit 7613b72
Show file tree
Hide file tree
Showing 133 changed files with 6 additions and 3,135 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ clean: clean-deprecated
rm -f bin/postgres-operator
rm -rf licenses/*/
[ ! -d testing/kuttl/e2e-generated ] || rm -r testing/kuttl/e2e-generated
[ ! -d testing/kuttl/e2e-generated-other ] || rm -r testing/kuttl/e2e-generated-other
[ ! -f hack/tools/setup-envtest ] || rm hack/tools/setup-envtest
[ ! -d hack/tools/envtest ] || { chmod -R u+w hack/tools/envtest && rm -r hack/tools/envtest; }
[ ! -d hack/tools/pgmonitor ] || rm -rf hack/tools/pgmonitor
Expand All @@ -85,6 +84,8 @@ clean-deprecated: ## Clean deprecated resources
[ ! -d build/crunchy-postgres-exporter ] || rm -r build/crunchy-postgres-exporter
@# CRDs used to require patching
[ ! -d build/crd ] || rm -r build/crd
@# Old testing directories
[ ! -d testing/kuttl/e2e-generated-other ] || rm -r testing/kuttl/e2e-generated-other


##@ Deployment
Expand Down Expand Up @@ -228,7 +229,6 @@ generate-kuttl: export KUTTL_PSQL_IMAGE ?= registry.developers.crunchydata.com/c
generate-kuttl: export KUTTL_TEST_DELETE_NAMESPACE ?= kuttl-test-delete-namespace
generate-kuttl: ## Generate kuttl tests
[ ! -d testing/kuttl/e2e-generated ] || rm -r testing/kuttl/e2e-generated
[ ! -d testing/kuttl/e2e-generated-other ] || rm -r testing/kuttl/e2e-generated-other
bash -ceu ' \
case $(KUTTL_PG_VERSION) in \
16 ) export KUTTL_BITNAMI_IMAGE_TAG=16.0.0-debian-11-r3 ;; \
Expand All @@ -245,7 +245,7 @@ generate-kuttl: ## Generate kuttl tests
source="$${1}" target="$${1/e2e/e2e-generated}"; \
mkdir -p "$${target%/*}"; render < "$${source}" > "$${target}"; \
shift; \
done' - testing/kuttl/e2e/*/*.yaml testing/kuttl/e2e-other/*/*.yaml testing/kuttl/e2e/*/*/*.yaml testing/kuttl/e2e-other/*/*/*.yaml
done' - testing/kuttl/e2e/*/*.yaml testing/kuttl/e2e/*/*/*.yaml

##@ Generate

Expand Down
13 changes: 2 additions & 11 deletions testing/kuttl/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,19 +74,10 @@ calling the `make generate-kuttl` target:
KUTTL_PG_VERSION=13 KUTTL_POSTGIS_VERSION=3.0 make generate-kuttl
```

This will loop through the files under the `e2e` and `e2e-other` directories and create matching
files under the `e2e-generated` and `e2e-generated-other` directories that can be checked for
This will loop through the files under testing directories and create matching
files under testing + `generated` directories that can be checked for
correctness before running the tests.

Please note, `make check-kuttl` does not run the `e2e-other` tests. To run the `postgis-cluster`
test, you can use:

```
kubectl kuttl test testing/kuttl/e2e-generated-other/ --timeout=180 --test postgis-cluster`
```

To run the `gssapi` test, please see testing/kuttl/e2e-other/gssapi/README.md.

To prevent errors, we want to set defaults for all the environment variables used in the source
YAML files; so if you add a new test with a new variable, please update the Makefile with a
reasonable/preferred default.
7 changes: 0 additions & 7 deletions testing/kuttl/e2e-other/autogrow-volume/00-assert.yaml

This file was deleted.

6 changes: 0 additions & 6 deletions testing/kuttl/e2e-other/autogrow-volume/01-create.yaml

This file was deleted.

6 changes: 0 additions & 6 deletions testing/kuttl/e2e-other/autogrow-volume/02-add-data.yaml

This file was deleted.

12 changes: 0 additions & 12 deletions testing/kuttl/e2e-other/autogrow-volume/03-assert.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions testing/kuttl/e2e-other/autogrow-volume/04-assert.yaml

This file was deleted.

12 changes: 0 additions & 12 deletions testing/kuttl/e2e-other/autogrow-volume/05-check-event.yaml

This file was deleted.

9 changes: 0 additions & 9 deletions testing/kuttl/e2e-other/autogrow-volume/README.md

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

32 changes: 0 additions & 32 deletions testing/kuttl/e2e-other/autogrow-volume/files/02-create-data.yaml

This file was deleted.

Loading

0 comments on commit 7613b72

Please sign in to comment.