Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile a pgAdmin StatefulSet, Pod PVC and ConfigMap #3738

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Reconcile a pgAdmin StatefulSet, Pod PVC and ConfigMap #3738

merged 2 commits into from
Oct 3, 2023

Conversation

tjmoore4
Copy link
Contributor

@tjmoore4 tjmoore4 commented Oct 2, 2023

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)
    Add the reconciliation logic for the main initial elements for pgAdmin. Includes initial configuration options for the StatefulSet and example implementations for the ConfigMap, PVC and Status block

Other Information:

benjaminjb
benjaminjb reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, happy to discuss tmrw

examples/pgadmin/pgadmin.yaml Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/apply.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/labels.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller_test.go Outdated Show resolved Hide resolved
jmckulk
jmckulk reviewed Oct 3, 2023
View reviewed changes
examples/pgadmin/pgadmin.yaml Show resolved Hide resolved
internal/controller/standalone_pgadmin/helpers_test.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/labels.go Outdated Show resolved Hide resolved
pkg/apis/postgres-operator.crunchydata.com/v1beta1/standalone_pgadmin_types.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/apply.go Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/controller.go Show resolved Hide resolved
@tjmoore4 tjmoore4 force-pushed the reconcile-pgadmin branch 2 times, most recently from cf20e65 to 1782fea Compare October 3, 2023 19:14
@tjmoore4 tjmoore4 marked this pull request as ready for review October 3, 2023 19:15
jmckulk
jmckulk reviewed Oct 3, 2023
View reviewed changes
internal/controller/standalone_pgadmin/pod.go

// podConfigFiles returns projections of pgAdmin's configuration files to
// include in the configuration volume.
func podConfigFiles(configmap *corev1.ConfigMap, pgadmin v1beta1.PGAdmin) []corev1.VolumeProjection {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podVolumes 💭

benjaminjb
benjaminjb approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments, not blockers -- nice file splitting.

internal/controller/standalone_pgadmin/configmap.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/configmap.go Outdated Show resolved Hide resolved
internal/controller/standalone_pgadmin/pod_test.go Outdated Show resolved Hide resolved
internal/naming/names.go Outdated Show resolved Hide resolved
@tjmoore4
Reconcile a pgAdmin StatefulSet, Pod PVC and ConfigMap
31adf43 
Add the reconciliation logic for the main initial elements for
pgAdmin. Includes initial configuration options for the StatefulSet
and example implementations for the ConfigMap, PVC and Status block
@tjmoore4
Update PostgresCluster example to RWO Volumes
1a36cf6
@tjmoore4 tjmoore4 requested a review from benjaminjb October 3, 2023 20:50
@tjmoore4 tjmoore4 merged commit 6407a4f into CrunchyData:master Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmckulk jmckulk jmckulk approved these changes

@cbandy cbandy cbandy left review comments

@benjaminjb benjaminjb benjaminjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjmoore4 @cbandy @benjaminjb @jmckulk