-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OLM installer bundles for pgAdmin API updates #3743
Conversation
requests: | ||
storage: 1Gi | ||
serverGroups: | ||
- name: "Crunchy Postgres for Kubernetes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a comment about "This will grab all postgresclusters" be helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea. I thought about it a bit, but we don't have anything similar in our other examples. I can try a test and see how it looks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To follow up, I did a test and our current bundle generation method strips out comments, so I don't know that there's a simple way to add that at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with a quick look I saw nothing that jumped out at me - is there something that you want me to focus on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look. Mainly the line in installers/olm/description.md
. Is that sufficient or is there anything else you think is worth mentioning there?
ad5e616
to
5367ab1
Compare
5367ab1
to
6a8a129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm technically - wording seems fine to me, but will leave that to others
This commit adds a new OLM example for the pgAdmin CRD and updates the bundle description file.
6a8a129
to
4a37f9d
Compare
Checklist:
Type of Changes:
What is the new behavior (if this is a feature change)?
This PR adds a new OLM example for the pgAdmin CRD and updates the bundle description file.
Other Information: