Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OLM installer bundles for pgAdmin API updates #3743

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

tjmoore4
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)
    This PR adds a new OLM example for the pgAdmin CRD and updates the bundle description file.

Other Information:

requests:
storage: 1Gi
serverGroups:
- name: "Crunchy Postgres for Kubernetes"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a comment about "This will grab all postgresclusters" be helpful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea. I thought about it a bit, but we don't have anything similar in our other examples. I can try a test and see how it looks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To follow up, I did a test and our current bundle generation method strips out comments, so I don't know that there's a simple way to add that at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with a quick look I saw nothing that jumped out at me - is there something that you want me to focus on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. Mainly the line in installers/olm/description.md. Is that sufficient or is there anything else you think is worth mentioning there?

@tjmoore4 tjmoore4 force-pushed the olm-pgadmin-api branch 4 times, most recently from ad5e616 to 5367ab1 Compare October 12, 2023 21:55
Copy link
Collaborator

@jmckulk jmckulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm technically - wording seems fine to me, but will leave that to others

This commit adds a new OLM example for the pgAdmin CRD and updates
the bundle description file.
@tjmoore4 tjmoore4 merged commit b05eb54 into CrunchyData:master Oct 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants