Snapshot dedicated pvc #3997
Merged
Snapshot dedicated pvc #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsessler7
force-pushed
the
snapshot-dedicated-pvc
branch
2 times, most recently
from
3f250c2 to
4799a2f
Compare
cbandy
reviewed
Sep 24, 2024
tony-landreth
approved these changes
Sep 26, 2024
cbandy
reviewed
Sep 26, 2024
| // VolumeSnapshots, return an error, otherwise return nil. | ||
| volumeSnapshotsExist, err := r.GroupVersionKindExists("snapshot.storage.k8s.io/v1", "VolumeSnapshot") | ||
| volumeSnapshotKindExists, err := r.GroupVersionKindExists("snapshot.storage.k8s.io/v1", "VolumeSnapshot") |
There was a problem hiding this comment.
📝 I keep forgetting about #3973.
There was a problem hiding this comment.
Yeah... kind of want to get this PR merged, but maybe after it is merged I can add to the api discovery PR to make snapshots use it and then we can merged that one.
cbandy
approved these changes
Oct 2, 2024
…finishes successfully, do a delta restore into dedicated volume and then snapshot the volume. Add/adjust tests for snapshots. Co-authored by: Anthony Landreth <tony.landreth@crunchydata.com>
dsessler7
force-pushed
the
snapshot-dedicated-pvc
branch
from
5d39aed to
151cba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Currently, when the operator creates a VolumeSnapshot, it does it on the cluster's primary pgdata volume with the database running.
What is the new behavior (if this is a feature change)?
When snapshots are enabled a dedicated snapshot volume (DSV) will be created and every time a backup completes, a delta restore will be done in the DSV. When the restore finishes successfully, a snapshot will be created of the DSV.
Other Information: