Check that snapshot.Status is not nil when checking Status properties. #4021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
We currently don't check that a snapshot's Status isn't nil when checking Status properties. There is an edge case where a snapshot does not yet have a
Status
which can lead to a nil pointer dereference.What is the new behavior (if this is a feature change)?
We now check for the existence of
snapshot.Status
when checking a snapshot's Status properties.Other Information: