Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Go toolchain installed by actions/setup-go #4023

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Oct 29, 2024

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Testing enhancement

Other Information:

Issue: PGO-1898

Since version 1.21, Go may automatically download a different version of Go.
Disable this behavior so that entire pipelines use only one version.

The "go" and "toolchain" directives indicate the minimum version of Go
required when importing and developing the module, respectively. We are
concerned only with compatibility, so downgrade "toolchain" to 1.22.0.

Issue: PGO-1898
See: https://go.dev/doc/toolchain
@cbandy cbandy requested a review from dsessler7 October 29, 2024 23:04
Copy link
Contributor

@dsessler7 dsessler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbandy cbandy merged commit 55f878b into CrunchyData:master Oct 30, 2024
15 checks passed
@cbandy cbandy deleted the go-toolchain branch October 30, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants