Refactor: Pass client.Object types by reference #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client.Object interface is implemented only by the pointer type. Subtle bugs can arise from passing a value when you intended to pass a reference. See: 96132b8 See: https://go.dev/wiki/MethodSets
cbandy
force-pushed
the
reference-types
branch
from
7123613 to
34cdcbf
Compare
benjaminjb
approved these changes
Nov 27, 2024
cbandy
force-pushed
the
reference-types
branch
from
d5a3e49 to
bb37061
Compare
cbandy
commented
Nov 27, 2024
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
| ) | ||
|
|
||
| // Requests converts objects to a slice of [reconcile.Request]. | ||
| func Requests[T client.Object](objects ...T) []reconcile.Request { |
There was a problem hiding this comment.
This has convinced me that "slice of plain objects" pays dividends, even now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm confident about the first commit. The others switch from List types, which seem like a Kubernetes API concern, to slices of "plain old objects." That seems better positioned for generics and
slices, but I didn't look for those opportunities here. 🤔 Perhaps those commits should wait until then.