Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added favicon #228

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

SaranshBangar
Copy link
Contributor

@SaranshBangar SaranshBangar commented May 22, 2024

Resolves issue #169

Description -> Added a favicon in the index.html file

Resolves image ->

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SaranshBangar! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@SaranshBangar
Copy link
Contributor Author

Resolves issue #227

@PratikMane0112
Copy link
Contributor

I have already fixed it in #199

@SaranshBangar SaranshBangar mentioned this pull request May 22, 2024
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

1 similar comment
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@thecuriousteam
Copy link
Contributor

can you check our asset folder we have high resolution images, please can you add @SaranshBangar

@SaranshBangar
Copy link
Contributor Author

can you check our asset folder we have high resolution images, please can you add @SaranshBangar

Sir, I have used favicon image from assets folder itself, the image path is src/assets/Landing-Page-Assets/CDC.jpg

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @SaranshBangar

2 similar comments
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @SaranshBangar

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @SaranshBangar

@SaranshBangar
Copy link
Contributor Author

@thecuriousteam Is there any issue in my PR?

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @SaranshBangar

2 similar comments
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @SaranshBangar

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @SaranshBangar

@thecuriousteam thecuriousteam merged commit 5336877 into Curious-Ecosystem:main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants