-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added favicon #228
Added favicon #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @SaranshBangar! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
Resolves issue #227 |
I have already fixed it in #199 |
Hi there! This issue is still open. We are looking forward to your response. |
1 similar comment
Hi there! This issue is still open. We are looking forward to your response. |
can you check our asset folder we have high resolution images, please can you add @SaranshBangar |
Sir, I have used favicon image from assets folder itself, the image path is |
Hi there! This issue is still open. We are looking forward to your response. |
2 similar comments
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
@thecuriousteam Is there any issue in my PR? |
Hi there! This issue is still open. We are looking forward to your response. |
2 similar comments
Hi there! This issue is still open. We are looking forward to your response. |
Hi there! This issue is still open. We are looking forward to your response. |
Resolves issue #169
Description -> Added a favicon in the
index.html
fileResolves image ->