Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: match WarmableInterface::warmUp signature for SF 6.4 #18

Merged
merged 2 commits into from
Feb 16, 2024
Merged

fix: match WarmableInterface::warmUp signature for SF 6.4 #18

merged 2 commits into from
Feb 16, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 19, 2024 •
edited
Loading

I cannot guarantee this helps #17 but now it feels better indeed.

@simPod simPod mentioned this pull request Jan 19, 2024
Merged
@romm
Copy link
Member

romm commented Feb 16, 2024

Hi @simPod, thanks for the PR. I've removed the WarmUpCompatibility trait, because as far as I see it did not solve anything. We'll see if people are having issues because of it, but from the tests I've been running locally I'm quite confident.

@romm romm merged commit 2d6bba8 into CuyZ:master Feb 16, 2024
11 checks passed
@simPod simPod deleted the sf7 branch February 16, 2024 14:48
@romm romm mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simPod @romm